Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resolver no deps extras install self #8678

Merged
merged 4 commits into from
Aug 4, 2020
Merged

New resolver no deps extras install self #8678

merged 4 commits into from
Aug 4, 2020

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 2, 2020

Fix #8677. iter_dependencies(ignore_dependencies=True) feels weird, but I can’t think of a better argument name.

@uranusjr uranusjr requested review from pfmoore and pradyunsg August 2, 2020 00:25
@uranusjr
Copy link
Member Author

uranusjr commented Aug 2, 2020 •
edited
Loading

I dont understand the CI failures…

E       assert False
E        +  where False = contains_expected_lines("ERROR: broken 1.0 requires missing, which is not 
installed.\nbroken 1.0 requires conflict<1.0, but you'll have conflict 1.0 which is incompatible.\n", ['broken 
1.0 requires missing, which is not installed.', "broken 1.0 requires conflict<1.0, but you'll have conflict 1.0 
which is incompatible."])
E        +    where "ERROR: broken 1.0 requires missing, which is not installed.\nbroken 1.0 requires 
conflict<1.0, but you'll have conflict 1.0 which is incompatible.\n" = <tests.lib.TestPipResult object at 
0x7f2d6009be50>.stderr

But… the line is present? 😞

@pradyunsg
Copy link
Member

See #8674 for why the CI is failing. :)

@pradyunsg
Copy link
Member

How about... iter_requires(dependencies: bool = True)?

pradyunsg
pradyunsg reviewed Aug 2, 2020
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On board with the overall approach (yay technical debt!) and made a suggestion for naming. :)

@uranusjr uranusjr force-pushed the new-resolver-no-deps-extras-install-self branch from fc5bcd5 to 77cedcf Compare August 2, 2020 08:12
@uranusjr
Copy link
Member Author

uranusjr commented Aug 2, 2020 •
edited
Loading

I think it should be the other way around though? The base requirement of an ExtrasCandidate is a dependency (in resolvelib semantics), but not listed in Requires-Dist. So it would be

def iter_dependencies(self, include_requires: bool) -> Iterable[Optional[Requirement]]:
    """Return dependencies of this candidate.

    :param include_requires: Dependencies from Requires-Dist are returned only if this is true.
    """

@pradyunsg
Copy link
Member

Indeed! Let's do that.

@uranusjr
Copy link
Member Author

uranusjr commented Aug 2, 2020

Updated.

@rouge8 rouge8 mentioned this pull request Aug 3, 2020
Closed
@brainwane brainwane requested a review from pradyunsg August 3, 2020 17:03
@uranusjr uranusjr added this to the 20.2.1 milestone Aug 3, 2020
@uranusjr uranusjr closed this Aug 3, 2020
@uranusjr uranusjr reopened this Aug 3, 2020
@pradyunsg pradyunsg merged commit 4fa31d5 into pypa:master Aug 4, 2020
@uranusjr uranusjr deleted the new-resolver-no-deps-extras-install-self branch August 4, 2020 01:58
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Aug 4, 2020
@pradyunsg
Merge pull request pypa#8678 from uranusjr/new-resolver-no-deps-extra…
552b837 
…s-install-self
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pfmoore pfmoore Awaiting requested review from pfmoore

@pradyunsg pradyunsg Awaiting requested review from pradyunsg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.2.1
Development

Successfully merging this pull request may close these issues.

'pip wheel --no-deps' doesn't work with extras on the new resolver
2 participants
@uranusjr @pradyunsg